[U-Boot-Users] [PATCH] qemu-mips: add CFI support

[Wolfgang Denk]

In message <1207816295-9586-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
...
> @@ -74,16 +74,12 @@
>  #define CONFIG_CMD_ELF
>  #define CONFIG_CMD_FAT
>  #define CONFIG_CMD_EXT2
> -#undef  CONFIG_CMD_IMLS
> -#undef  CONFIG_CMD_FLASH
> -#undef  CONFIG_CMD_LOADB
^^^^^^^^^^^^^^^^^^^^^^^^^^^
> -#undef  CONFIG_CMD_LOADS
^^^^^^^^^^^^^^^^^^^^^^^^^^^
>  #define CONFIG_CMD_DHCP
> +#define CONFIG_CMD_PING
^^^^^^^^^^^^^^^^^^^^^^^^^^^

These changes are neither related to CFI support nor mentioned in the
subject. This is misleading.

> -#define	CFG_MONITOR_LEN		(192 << 10)
> +#define	CFG_MONITOR_LEN		(192 << 11)

It would be much better readable if you wrote "384 << 10" instead -
everybody will then see immediately that this is 384 KiB.

But - is this really needed? Has your image become that big?
Please check!!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Prepare for tomorrow -- get ready.
	-- Edith Keeler, "The City On the Edge of Forever",
	   stardate unknown