[U-Boot-Users] [PATCH] fw_printenv: Add -v and -q options.

[Wolfgang Denk]

In message <1208527021-16460-1-git-send-email-Joakim.Tjernlund at transmode.se> you wrote:
> Add -v for verbose output, "Unlocking flash...", "Done" etc.
> Add -q for quiet operation, do not print error and verbose
> messages.

This seems kind of redundandant to me.

And not printing error messages seems an error to me.

> Add a --help(-help, -?) option too.
> 
> The -q option is intended for scripting.

Feel free to add "2>/dev/null" to your scripts when you think this is
really what you want to have.

> +int check_option(int *argc, char *argv[], const char *option)
> +{
> +	int i,j;
> +
> +	for (i = 1; i < *argc; i++)
> +		if (strcmp (argv[i], option) == 0) {
> +			for (j=i; j < *argc; j++)
> +				argv[j] = argv[j+1]; /* remove option */
> +			*argc -= 1;
> +			return 1;
> +		}
> +	return 0;
> +}
> +
> +void check_quiet(int *argc, char *argv[])
> +{
> +	if (check_option(argc, argv, "-q"))
> +		fw_quiet = 1;
> +}
> +
> +void check_verbose(int *argc, char *argv[])
> +{
> +	if (check_option(argc, argv, "-v"))
> +		fw_verbose = 1;
> +}

I've seen many diffeent versions of argument checking code.  This  is
not  a  nice one. See for example "tools/mkimage.c" for the "classic"
approach.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Perl already has an IDE.  It's called Unix.
                      -- Tom Christiansen in 375bd509 at cs.colorado.edu