[U-Boot-Users] [PATCH] Blackfin: implement go/boote wrappers

Wolfgang Denk wd at denx.de
Mon Apr 21 14:13:12 CEST 2008


In message <200804210635.08416.vapier at gentoo.org> you wrote:
>
> well, duh.  my point was that you're making "go" get duplicated just to 
> conform to documentation.  the command name itself "go" doesnt really conjurn 
> up usage of "executing an application and returning" ... fits better with "go 
> to this location and never come back".  "run" probably would have been a 
> better name.  but that's hindsight for you.

You are right. Today I would probably name this "call".

> > 	go [ -cache={off,d-off,i-off,on,d-on,i-on} ] addr [ args ... ]
> 
> cache is just an example.  other arches may want to do other sort of "system 
> breakdown/cleanup" before relinquishing control.  option flags to commands

As the situation is, other arches seem to be just fine  as  it.  It's
only BF which needs a pork sausage.

> really doesnt fit the style of u-boot (i expect that sort of painful option
> parsing in redboot, not really u-boot).

I don;t like it either, but just ading random new commands is even
worse.

> so we can do:
> 	go [-noret] addr [args...]

Ummm... "no return" programs is just an example.  Other  pograms  may
want  to  do  other  sort of "system breakdown/cleanup" before relin-
quishing control.

> or we can add "jump" to cmd_boot.c and merge the differences by just using > a 
> function pointer to "do_go_exec" or "do_jump_exec".

Adn then we add "call" and "exec" and "do" and so oon just for  other
needed options? I say no.

> i never said Blackfin was the only thing that mattered.  in fact, my goal is 
> to make it so that people using this facility get a more standard initial 
> environment before they start taking over the system.  i guess i wont point
> out the U-Boot policy about not using interrupts ...

Are you aware that U-Boot does use interrupts here and there? That we
actually  provide  functions  to  register  interrupt   handlers   to
standalone programs, etc. ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Shakespeare's Law of Prototyping: (Hamlet III, iv, 156-160)
        O, throw away the worser part of it,
        And live the purer with the other half.




More information about the U-Boot mailing list