[U-Boot-Users] [PATCH] mx31ads: fix loadaddr environment variable define

Guennadi Liakhovetski lg at denx.de
Sun Apr 27 22:14:39 CEST 2008


Arithmetic expressions do not get evaluated under stringification.
Thanks to Felix Radensky for reporting.

Signed-off-by: Guennadi Liakhovetski <lg at denx.de>

---

On Sun, 27 Apr 2008, Felix Radensky wrote:

> I've installed 1.3.3-rc1 on i.MX31ADS evaluation board
> and encountered several problems
> 
> 1. loadaddr environment variable (as reported by printenv)
>    is defined as
> 
> 	loadaddr=(0x80000000 + 0x800000)
> 
>    This results in image loaded at address 0x0, and boot gets stuck.
>    Redefining loadaddr as 0x80800000 fixes the problem.

Thanks for reporting, patch below. Feel free to add your Acked- or 
Tested-by.

> 2. dhcp command is undefined, only bootp is available.

It wasn't needed in the environment the configuration has been programmed 
for. Patches are welcome:-)

Thanks
Guennadi

 include/configs/mx31ads.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/configs/mx31ads.h b/include/configs/mx31ads.h
index 5286e1f..301afd5 100644
--- a/include/configs/mx31ads.h
+++ b/include/configs/mx31ads.h
@@ -87,7 +87,7 @@
 #define CONFIG_NETMASK		255.255.255.0
 #define CONFIG_IPADDR		192.168.23.168
 #define CONFIG_SERVERIP		192.168.23.2
-#define CONFIG_LOADADDR		(CSD0_BASE + 0x800000)	/* loadaddr env var */
+#define CONFIG_LOADADDR		0x80800000	/* loadaddr env var */
 
 #define	CONFIG_EXTRA_ENV_SETTINGS					\
 	"netdev=eth0\0"							\
-- 
1.5.4


> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
> Don't miss this year's exciting event. There's still time to save $100. 
> Use priority code J8TL2D2. 
> http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
> _______________________________________________
> U-Boot-Users mailing list
> U-Boot-Users at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/u-boot-users
> 

---
Guennadi Liakhovetski




More information about the U-Boot mailing list