[U-Boot-Users] [PATCH V2] Add the Harris QUAD100HD AMCC 405EP-based board.

[Gary Jennejohn]

On Sun, 27 Apr 2008 14:07:39 +0200
Stefan Roese <sr at denx.de> wrote:

> On Saturday 26 April 2008, Wolfgang Grandegger wrote:
> > > Please use only one coding style in one file. So either:
> > >
> > > 	func();
> > >
> > > or
> > >
> > > 	func ();
> > >
> > > Since this file mostly consists of the func() style I suggest you switch
> > > to this one completely.
> >
> > Do we really have the choice?
> 
> I definitely think so. I am aware of the coding style rule set be Wolfgang to 
> use the "func ()" style. But I never use this style in the files I write from 
> scratch. This is because I am also doing a lot of Linux development, and here 
> the "func()" style is required/preferred. And if you take a look at the code 
> posted by other developers, most of it uses the "func()" style. It definitely 
> seems to be more common nowadays. At least from my experience.
> 

So now I'm totally confused!  As Wolfgang Denk wrote in his followup:

The README says:

    All contributions to U-Boot should conform to the Linux kernel
    coding style; see the file "Documentation/CodingStyle" and the script
    "scripts/Lindent" in your Linux kernel source directory.  In sources
    originating from U-Boot a style corresponding to "Lindent -pcs" (adding
    spaces before parameters to function calls) is actually used.

The Linux coding style, as you pointed out,  is to _not_ use spaces
between the function name and the first brace, i.e. "foo()" and not
"foo ()".

So WTF?

---
Gary Jennejohn
*********************************************************************
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
*********************************************************************