[U-Boot-Users] [PATCH] LinkStation: fix compiler warning, add a maintainer

Guennadi Liakhovetski g.liakhovetski at gmx.de
Mon Apr 28 14:35:57 CEST 2008


out_8 wants a pointer to an unsigned as the first argument. Add a 
maintainer for Linkstation boards.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski at gmx.de>

---

On Mon, 28 Apr 2008, Wolfgang Denk wrote:

> In message <Pine.LNX.4.64.0803310112130.6825 at axis700.grange> you wrote:
> > This patch is based on the port by Mihai Georgian (see linkstation.c for 
> > Copyright information) and implements support for LinkStation / KuroBox HD 
> > and HG PPC models from Buffalo Technology, whereby HD is deactivated at 
> > the moment, pending network driver fixing.
> 
> The code throws a lot of compiler warnings:
> 
> ===== LOG/linkstation_HGLAN =====
> hwctl.c: In function 'miconCntl_SendUart':
> hwctl.c:30: warning: pointer targets in passing argument 1 of 'out_8' differ in signedness

Patch below.

diff --git a/board/linkstation/hwctl.c b/board/linkstation/hwctl.c
index 9db128a..2e5b5c8 100644
--- a/board/linkstation/hwctl.c
+++ b/board/linkstation/hwctl.c
@@ -27,7 +27,7 @@
 /*--------------------------------------------------------------*/
 static inline void miconCntl_SendUart(unsigned char dat)
 {
-	out_8((char *)AVR_PORT, dat);
+	out_8((unsigned char *)AVR_PORT, dat);
 	mdelay(1);
 }
 
diff --git a/MAINTAINERS b/MAINTAINERS
index d1782b4..58f833c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -408,6 +408,10 @@ John Zhan <zhanz at sinovee.com>
 
 	svm_sc8xx		MPC8xx
 
+Guennadi Liakhovetski <g.liakhovetski at gmx.de>
+
+	linkstation		MPC8241
+
 -------------------------------------------------------------------------
 
 Unknown / orphaned boards:




More information about the U-Boot mailing list