[U-Boot-Users] [PATCH] (Resubmit) ADD ARM AMBA PL031 RTC Support

[Hebbar]

Hi,

>Why do we need the #ifdef's here? It seems this is a board specific
>configuration anyway, i. e. we don't expect for example other RTC chips
>to be used on this board, or do we?

Also I Just Checked u-boot-1.3.3/board/bc3450/bc3450.c. Even here it has 
a declaration for RTC @ line 47

#ifdef CONFIG_RTC_MPC5200
#include <rtc.h>
#endif

@ line 371

#ifdef CONFIG_RTC_MPC5200
	struct rtc_time t;

	/* set to Wed Dec 31 19:00:00 1969 */
	t.tm_sec = t.tm_min = 0;
	t.tm_hour = 19;
	t.tm_mday = 31;
	t.tm_mon = 12;
	t.tm_year = 1969;
	t.tm_wday = 3;

	rtc_set(&t);
#endif /* CONFIG_RTC_MPC5200 */


So i think its correct. Please Update me if i am wrong


Regards
Gururaja

-- 
View this message in context: http://www.nabble.com/-PATCH--%28Resubmit%29-ADD-ARM-AMBA-PL031-RTC-Support-tp18499969p18767539.html
Sent from the Uboot - Users mailing list archive at Nabble.com.