[U-Boot-Users] [PATCH 0/7 v2] SMDK6400 support
Guennadi Liakhovetski
lg at denx.de
Mon Aug 4 12:42:32 CEST 2008
Hi,
this is version 2 of the smdk6400 patch series. I hope, I took care of all
comments, apart of these ones:
On Thu, 31 Jul 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > +#ifdef CONFIG_NAND_SPL
> > +static u_char nand_read_byte(struct mtd_info *mtd)
> > +{
> > + struct nand_chip *this = mtd->priv;
> add an empty line
> > + return readb(this->IO_ADDR_R);
> > +}
> > +
> > +static void nand_write_byte(struct mtd_info *mtd, u_char byte)
> > +{
> > + struct nand_chip *this = mtd->priv;
> add an empty line
> > + writeb(byte, this->IO_ADDR_W);
> > +}
Sorry, looks like a matter of taste to me. There are also very few lines
over 80 characters left, but fixing them would look too awkward...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
More information about the U-Boot
mailing list