[U-Boot-Users] [PATCH] NAND boot: Update large page support for current API.

Scott Wood scottwood at freescale.com
Tue Aug 5 19:01:46 CEST 2008


Guennadi Liakhovetski wrote:
>>  	/* Begin command latch cycle */
>> -	this->cmd_ctrl(mtd, cmd, ctrl);
>> +	this->cmd_ctrl(mtd, cmd, NAND_CTRL_CLE | NAND_CTRL_CHANGE);
> 
> [snip]
> 
> See? you do the same! You replace short lowercase variable with long 
> uppercase macros:-) 

:-)

Yes, but in this case it's not just a name change; the old "ctrl" 
variable was stateful and thus less clear.

-Scott




More information about the U-Boot mailing list