[U-Boot-Users] [PATCH 5/7 v6] serial: add S3C64XX serial driver

Guennadi Liakhovetski lg at denx.de
Mon Aug 11 10:44:20 CEST 2008


On Sat, 9 Aug 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:

> > +	u32 reg;
> > +	u32 pclk_ratio = get_PCLK() / gd->baudrate;
> > +	int i;
> > +
> IMHO it's still obscur
> > +	/* PCLK / (16 * baudrate) - 1 */
> > +	reg = pclk_ratio / 16 - 1;
> > +	/* i = pclk_ratio % 16 */
> > +	i = pclk_ratio - (reg + 1) * 16;

Sorry, I don't understand how this can be made clearer yet. If you have 
any specific ideas, please let me know now, before v7 appears, because I 
would really like to make it final.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de




More information about the U-Boot mailing list