[U-Boot] [PATCH 3/7 v6] ARM: Add arm1176 core with S3C6400 SoC

[Jean-Christophe PLAGNIOL-VILLARD]

On 11:58 Sat 09 Aug     , Wolfgang Denk wrote:
> In message <20080809091101.GC18040 at game.jcrosoft.org> you wrote:
> > 
> > > +		/*
> > > +		 * for 10 ms clock period @ PCLK with 4 bit divider = 1/2 and
> > > +		 * prescaler = 16. Should be 10390 @33.25MHz and 15625 @ 50 MHz
> > > +		 */
> > > +		timer_load_val = get_PCLK() / PRESCALER * (100 / 4); /* 100s */
> > > +		/*printf("Calculated %lu timer_load_val\n", timer_load_val);*/
> > please remove if not need
> 
> Or even better convert it into a debug() call so it can be enabled
> again for debugging purposes.
> 
> > > +		timers->TCFG1 = (timers->TCFG1 & ~0xf0000) | 0x20000;
> > > +	}
> > > +
> > please add some empty line to be more readable
> 
> No. One empty line os enough here.

please add some empty line to be more readable for the following blocks
> +     /* load value for 10 ms timeout */
> +     lastdec = timers->TCNTB4 = timer_load_val;
> +     /* auto load, manual update of Timer 4 */
> +     timers->TCON = (timers->TCON & ~0x00700000) | TCON_4_AUTO |
> +             TCON_4_UPDATE;
> +     /* auto load, start Timer 4 */
> +     timers->TCON = (timers->TCON & ~0x00700000) | TCON_4_AUTO | COUNT_4_ON;
> +     timestamp = 0;
[snip]


> > > +#define NFADDR           	(ELFIN_NAND_BASE+NFADDR_OFFSET)
> >                  ^^^^^^^^^^^
> > please remove whitesapce
> 
> Not remove, but use TABs vor vertical alignment.
That's my idea

Best Regards,
J.