[U-Boot] [PATCH] PPC4xx: PLB4 Arbiter and Memory Queue Optimizations

[Wolfgang Denk]

Dear Prodyut Hazarika,

In message <0CA0A16855646F4FA96D25A158E299D604D290EC at SDCEXCHANGE01.ad.amcc.com> you wrote:
>
> > I don't particularly like this extra "{" level without need. Please
> remove it.
> 
> The { is kept to avoid warnings. Without the "{", I would need to define
> the local variable near
> The beginning of the function. That would cause warning (Unused

Yes, that's where variable definitions belong.

> variable) for non 440EX/GT families.
> Please advice whether you want this warning to come up, if I remove the

No, warnings are not allowed. You can #ifdef the declaration, can't
you?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When you die, the first thing you lose is your life. The  next  thing
is the illusions.                       - Terry Pratchett, _Pyramids_