[U-Boot] [PATCH] ppc4xx: Optimize PLB4 arbiter and Memory Queue settings for PPC 440SP/SPe and 460EX/GT/SX

[Prodyut Hazarika]

Thanks Stefan. Please see replies below.

> Patch is line-wrapped this time. I suggest that you use git-send-email to send 
> your git formatted patches.

I will use git-send-email next time to avoid these issues


>> +    defined (CONFIG_460GT) || defined(CONFIG_460SX)
>No space after "defined" please. -> "defined("

Sorry about that. I will be careful in future.


>> +#if defined(CONFIG_440SP) || defined(CONFIG_440SPE) || \
>> +    defined(CONFIG_460EX) || defined(CONFIG_460GT)  || \
>> +    defined(CONFIG_405EX) || defined(CONFIG_460SX)
>
> Why don't you add 440GP and 440GX here? From my understanding they would 
> benefit from this pipeline change too.

400GP/GX have a slightly different register layout. I plan to make a separate
patch adding the defines and the changes in a separate patch.


>> +#define plb0_revid                (PLB_ARBITER_BASE+ 0x00)
>> +#define plb0_acr                  (PLB_ARBITER_BASE+ 0x01)
>
>No upper case defines in this patch. I'm fine with this as long as we update 
>this in a later patch.

I plan to make a cleanup patch soon. Felt it was appropriate to separate them.

>And from a quick check of the manuals the 440GP/GX have a slightly different 
>register layout. Is this the reason you didn't include those PPC's in this 
>patch version? What are your plans for those PPC's?

That is right. I want to send a separate patch for the same.

Also could you please let me know whether you applied the patch. Sorry for the line wrap issues - I will use git-send-email next time.

Regards,
Prodyut Hazarika

=======================
Staff S/W Engineer
AMCC
=======================
--------------------------------------------------------

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.