[U-Boot] [PATCH] ppc4xx: Read pipeline depth set to 4 for PPC440SP/SPE, PPC405EX, PPC460EX/GT/SX processors

Prodyut Hazarika phazarika at amcc.com
Wed Aug 13 22:19:52 CEST 2008


Dear Wolfgang,
Thanks for the clarification. I will change  include/asm-ppc/ppc4xx-sdram.h to tabs and resubmit.

But one more question. 

> > 
> > #if defined(CONFIG_440EP) || defined (CONFIG_440GR) || \
> >    ^^ space here        ^^ space here
> >     defined(CONFIG_440EPX) || defined(CONFIG_440GR) 

> This is not what we are talking about. This part of the code is OK.

I want to understand why is space alignment okay here. The coding guidelines state that we must use tabs for vertical alignment. Does this rule not apply to defines? If so, the coding guidelines doc should be updated.

Best regards,
Prodyut Hazarika

=====================
Staff S/W Engineer
AMCC
=====================
--------------------------------------------------------

CONFIDENTIALITY NOTICE: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and contains information that is confidential and proprietary to Applied Micro Circuits Corporation or its subsidiaries. It is to be used solely for the purpose of furthering the parties' business relationship. All unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.



More information about the U-Boot mailing list