[U-Boot] [PATCH] [RFC] Standardize bootp, tftpboot, rarpboot, dhcp, and nfs command descriptions

Peter Tyser ptyser at xes-inc.com
Thu Aug 14 00:11:32 CEST 2008


Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
---
Not sure if "boot" is the proper word to use in the command definitions
since the downloaded images are only booted if "autostart=yes", and
the majority of board configs don't have autostart set to yes.
I'd vote for changing the descriptions to "load image via...".
If a new, more granular bootm command is in the works,
it seems like even less people will autoboot an image
directly before doing some additional bootm commands to prep
for booting an OS. Do others have an opinion?

 common/cmd_net.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/common/cmd_net.c b/common/cmd_net.c
index 79e910c..af691a4 100644
--- a/common/cmd_net.c
+++ b/common/cmd_net.c
@@ -39,8 +39,8 @@ int do_bootp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	bootp,	3,	1,	do_bootp,
-	"bootp\t- boot image via network using BootP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"bootp\t- boot image via network using BOOTP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 int do_tftpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
@@ -62,7 +62,7 @@ int do_rarpb (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 U_BOOT_CMD(
 	rarpboot,	3,	1,	do_rarpb,
 	"rarpboot- boot image via network using RARP/TFTP protocol\n",
-	"[loadAddress] [bootfilename]\n"
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 
 #if defined(CONFIG_CMD_DHCP)
@@ -73,8 +73,8 @@ int do_dhcp (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 
 U_BOOT_CMD(
 	dhcp,	3,	1,	do_dhcp,
-	"dhcp\t- invoke DHCP client to obtain IP/boot params\n",
-	"\n"
+	"dhcp\t- boot image via network using DHCP/TFTP protocol\n",
+	"[loadAddress] [[hostIPaddr:]bootfilename]\n"
 );
 #endif
 
-- 
1.5.4.3




More information about the U-Boot mailing list