[U-Boot] [RFC] setting pio modes for IDE devices

Wolfgang Denk wd at denx.de
Fri Aug 15 20:12:30 CEST 2008


Dear "Steven A. Falco",

In message <48A5C296.1060801 at harris.com> you wrote:
> I realized that I should be checking to see if word 163 is applicable to
> the ATA device in question.  To do that, I need to call ata_id_is_cfa() from
> libata.h.  However, libata.h conflicts with ata.h because of duplicate
> enum values.
> 
> Therefore, this respin of the proposed patch deletes the duplicate enums
> from ata.h and instead includes libata.h to supply the enums.  Then, I
> can call ata_id_is_cfa() and more accurately detect PIO 5 and 6.
> 
> I believe cleaning up ata.h is a good thing, because duplicating the enums in
> both places invites them to get out of sync.

It is, but can you please split this into two independent patches?

Thanks in advance.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A father doesn't destroy his children.
	-- Lt. Carolyn Palamas, "Who Mourns for Adonais?",
	   stardate 3468.1.



More information about the U-Boot mailing list