[U-Boot] [PATCH 1/3] [RFC] Add support for early serial debug console

[Wolfgang Denk]

Dear Peter Tyser,

In message <1218835004-30729-2-git-send-email-ptyser at xes-inc.com> you wrote:
> Signed-off-by: Peter Tyser <ptyser at xes-inc.com>
> ---
>  README           |   11 +++++++++++
>  common/console.c |   34 +++++++++++++++++++++++++++++-----
>  common/serial.c  |    6 ++++--
>  include/common.h |    3 +++
>  lib_arm/board.c  |   12 ++++++++++++
>  lib_i386/board.c |   13 ++++++++++++-
>  lib_m68k/board.c |   12 ++++++++++++
>  lib_mips/board.c |   12 ++++++++++++
>  lib_ppc/board.c  |   13 ++++++++++++-
>  lib_sh/board.c   |   12 ++++++++++++
>  10 files changed, 119 insertions(+), 9 deletions(-)

I understand what you are trying todo, but I think it doesn't work.

You are invoking a numer of pretty complex functions (like readline()
and run_command() and ...) which in turn ionvoke other functions etc.
- all of them written in C with theassumption that they have a  valid
C runtime environment, which is simply not the case before relocation
to RAM.

And your patch seems to be inclomplete, it does not apply.

Some parts seem to be missing (like the necessary changes to eliminate
accesses to the console_buffer[] in BSS).


But in any case - You make a few commands usable, and the behaviour of
the remainig undefined. 

I don't think this is a good idea.

And we pay for this with a log of uglier code (many, many #ifdef's)
and increased memory size.


I'm interested to hear what others say, but so far I tend to reject
this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"'Tis true, 'tis pity, and pity 'tis 'tis true."
    - Poloniouius, in Willie the Shake's _Hamlet, Prince of Darkness_