[U-Boot] [PATCH] Replace references to extern console_buffer with a function call

Wolfgang Denk wd at denx.de
Sat Aug 16 09:50:43 CEST 2008


Dear Peter Tyser,

In message <1218839253.1273.148.camel at localhost.localdomain> you wrote:
>
> > But this is a boot loader, and size matters.
> 
> I had assumed gcc/ld would be smart enough to optimize the function call
> away, seeing as there is no conditional code in it.  I just tested, and
> the size was increased by 48 bytes for the MPC8548CDS reference board
> after applying the patch.  Inlining the console_buffer_addr() didn't get
> rid of the 48 bytes of bloat.
> 
> I guess this patch's fate will be the same as "[RFC] Add support for
> early serial debug console"...

Indeed, as this is the only application where the patch is needed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Fascinating, a totally parochial attitude.
	-- Spock, "Metamorphosis", stardate 3219.8



More information about the U-Boot mailing list