[U-Boot] [PATCH v2] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t

Kumar Gala galak at kernel.crashing.org
Mon Aug 18 21:57:49 CEST 2008


On Aug 18, 2008, at 2:49 PM, Scott Wood wrote:

> Kumar Gala wrote:
>> On Aug 18, 2008, at 2:30 PM, Wolfgang Denk wrote:
>>> Dear Kumar Gala,
>>>
>>> In message <Pine.LNX. 4.64.0808181422320.28491 at blarg.am.freescale.net 
>>> > you wrote:
>>>> Move to using the environment variables 'ethaddr', 'eth1addr',  
>>>> etc..
>>>> instead of bd->bi_enetaddr, bi_enet1addr, etc.
>>>>
>>>> This makes the code a bit more flexible to the number of ethernet
>>>> interfaces.  Right now we assume a max of 10 interfaces.
>>> Hm... where exactly is this artificial limit coming from? Do we  
>>> really
>>> need it?
>> We need some upper limit to stop checking at.
>
> It might be better (and more efficent) to iterate over the  
> environment, and check each name against the eth*addr pattern.

Its probably easier/less work to iterate over the aliases looking for  
"ethernet*" pattern, I can do that if its desired.

- k



More information about the U-Boot mailing list