[U-Boot] [U-Boot-Users] Request: s3c24xx getting its own start.S file ?

[Wolfgang Denk]

Dear Jean-Christophe,

In message <20080707072909.GA4412 at prithivi.gnumonks.org> Harald Welte wrote:
> 
> the problem is tha the main makefile always wants to build
> cpu/arm920t/start.o, and I don't see an easy way how it could be
> modified to build cpu/arm920t/s3c24x0/start.o instead.  At least until
> now I don't see an infrastructure for this.
> 
> > > the attached patch, where the cpu/arm920t/start.S #includes a
> > > cpu/arm920t/s3c24x0/start.S file.
> > > 
> > > It's not really nice, but otherwise I assure you anyone touching the
> > > arm920t start.S file again will find itself in #ifdef/endif hell, once
> > > all my s3c24xx related patches would be merged...
> > 
> > I really dislike the code duplication.
> 
> same here.  but I'd rather duplicate some 50-100 lines than have 300
> lines of completely unreadable #ifdef hell.
...

This falls mostly into your (i. e. ARM custodian) bailiwick. Could you
please make sure that we don't lose this thread? Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If it has syntax, it isn't user friendly.