[U-Boot] [PATCH] Fix OneNAND read_oob/write_oob functions compatability

Scott Wood scottwood at freescale.com
Tue Aug 19 01:27:31 CEST 2008


Kyungmin Park wrote:
>>> diff --git a/common/cmd_onenand.c b/common/cmd_onenand.c
>>> index 5e2062b..8d87b78 100644
>>> --- a/common/cmd_onenand.c
>>> +++ b/common/cmd_onenand.c
>>> @@ -85,15 +85,25 @@ int do_onenand(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[])
>>>                       ulong addr = simple_strtoul(argv[2], NULL, 16);
>>>                       ulong ofs = simple_strtoul(argv[3], NULL, 16);
>>>                       size_t len = simple_strtoul(argv[4], NULL, 16);
>>> -                     size_t retlen = 0;
>>>                       int oob = strncmp(argv[1], "read.oob", 8) ? 0 : 1;
>>> +                     struct mtd_oob_ops ops;
>>> +
>>> +                     ops.mode = MTD_OOB_PLACE;
>> I think this should be MTD_OOB_RAW.
> 
> What's the difference? In the code it can't support the MTD_OOB_RAW case.

Sorry, I was confusing PLACE with AUTO.

-Scott



More information about the U-Boot mailing list