[U-Boot] PCIe bridge pci memory limit register problem

[Danny Waldron]

The extra lines and line wrap are a result of my cut and paste, won't
happen again.

Any comments on the logic change?

------------------------------------------------------
Interphase    - Designed to Perform, Designed to Last (R)
Danny Waldron - Technical Support
Phone         - 214.654.5244
------------------------------------------------------
Disc Golf - the wind is my friend...or....every putt is an adventure for
this Texas Chain Ranger!
-----Original Message-----
From: wd at denx.de [mailto:wd at denx.de] 
Sent: Friday, August 15, 2008 4:55 PM
To: Danny Waldron
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] PCIe bridge pci memory limit register problem

Dear Danny,

In message
<D2CCC86D6128D043B074E2A927250D0694090D at EXMAIL.interphase.iphase.com>
you wrote:
> 
> So, here are the changes I did here local and am thinking that if this
> looks ok, then I will also need to add this to the pre-fetch logic as
> well.
> 
> void pciauto_postscan_setup_bridge(struct pci_controller *hose,
> 
>                       pci_dev_t dev, int sub_bus)
> 
> {
> 
>     struct pci_region *pci_mem = hose->pci_mem;
> 
>     struct pci_region *pci_prefetch = hose->pci_prefetch;
> 
>     struct pci_region *pci_io = hose->pci_io;
> 
>     unsigned int bridge_mem_base = 0;
> 

Why do you add allthese empty lines ???

> 
>     /* Configure bus number registers */
> 
>     pci_hose_write_config_byte(hose, dev, PCI_SUBORDINATE_BUS,
> 
>                    sub_bus - hose->first_busno);
> 
>  
> 
>     if (pci_mem) {
> 
>         /* Round memory allocator to 1MB boundary */
> 
>         pciauto_region_align(pci_mem, 0x100000);
> 
> +        /* danny, 15aug08
> 
> +         * read the the bus_lower value that was placed in the
> 
> +         * PCI_MEMORY_BASE register during
pciauto_prescan_setup_bridge
> 
> +         * and check to see if anything behind it consumed memory
> 
> +         */
> 
> +        pci_hose_read_config_word(hose, dev, PCI_MEMORY_BASE,
> &bridge_mem_base)
^^^^^^^^^^^^^^^^^^^

> ;
> 
> +
> 
> +        if((bridge_mem_base >> 16) == ((pci_mem->bus_lower &
> 0xfff00000) >> 16)
^^^^^^^^^^^^^^^^^^^^

Line wrapping.


If you want to discuss code changes, then please submit a regular
patch. Please see http://www.denx.de/wiki/U-Boot/Patches for
instructions.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A person who is more than casually interested in computers should  be
well  schooled in machine language, since it is a fundamental part of
a computer.                                           -- Donald Knuth