[U-Boot] [PATCH v3] fdt: rework fdt_fixup_ethernet() to use env instead of bd_t

[Wolfgang Denk]

Dear Kumar Gala,

In message <Pine.LNX.4.64.0808190924520.6029 at blarg.am.freescale.net> you wrote:
>
> --- a/common/fdt_support.c
> +++ b/common/fdt_support.c
> @@ -368,55 +368,96 @@ int fdt_fixup_memory(void *blob, u64 start, u64 size)
...
> +	/* walk the env looking for eth[.*]addr */
> +	for (i=0; env_get_char(i) != '\0'; i=nxt+1) {
> +		for (nxt=i; env_get_char(nxt) != '\0'; ++nxt)
> +			;

Please do not do this. env_get_char() is a function that is internal
to the environment handling code. It is not supposed to be exported to
arbitrary code. Please do not make any assumptions about the internals
of how the environment is stored.

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800