[U-Boot] [PATCH] Consolidate strmhz() implementation
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Tue Aug 19 23:00:13 CEST 2008
On 13:41 Mon 18 Aug , Haavard Skinnemoen wrote:
> ARM, i386, m68k and ppc all have identical implementations of strmhz().
> Other architectures don't provide this function at all.
>
> This patch moves strmhz() into lib_generic, reducing code duplication
> and providing a more unified API across architectures.
>
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen at atmel.com>
> ---
> include/common.h | 4 +++-
> lib_arm/board.c | 13 -------------
> lib_generic/Makefile | 1 +
> lib_generic/strmhz.c | 36 ++++++++++++++++++++++++++++++++++++
> lib_i386/board.c | 13 -------------
> lib_m68k/board.c | 17 -----------------
> lib_ppc/board.c | 13 -------------
> 7 files changed, 40 insertions(+), 57 deletions(-)
> create mode 100644 lib_generic/strmhz.c
>
When I read the patch, I really like it. But when I take a look on all board.c
I've seen 2 others functions which are commom.
Could we use the patch that reply to this message instead?
Best Regards,
J.
More information about the U-Boot
mailing list