[U-Boot] [PATCH] common/envs: Move conditional compilation to Makefile
Wolfgang Denk
wd at denx.de
Thu Aug 21 01:50:26 CEST 2008
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <1218978288-9313-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> rename CFG_ENV_IS_IN_* to CONFIG_ENV_IS_IN_*
> and CFG_ENV_IS_NOWHERE to CONFIG_ENV_IS_NOWHERE
>
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
...
> 535 files changed, 936 insertions(+), 978 deletions(-)
>
> due to ML limits
>
> patch at git://git.denx.de/u-boot-arm.git Makefile
Note that this is NOT the way how big patches are supposed to be
handled.
Please make a patch available for review.
[How big is that patch, btw?]
Note that it would have been easy to keep the patch small, for example
by handling CFG_ENV_IS_IN_FLASH, CFG_ENV_IS_IN_NVRAM,
CFG_ENV_IS_IN_EEPROM, CFG_ENV_IS_IN_DATAFLASH, CFG_ENV_IS_IN_NAND, and
CONFIG_ENV_IS_NOWHERE each in a patch separately.
I really dislike this.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
EMACS belongs in <sys/errno.h>: Editor too big!
More information about the U-Boot
mailing list