[U-Boot] [PATCH] Consolidate strmhz() implementation
Wolfgang Denk
wd at denx.de
Thu Aug 21 01:57:14 CEST 2008
Dear Jean-Christophe,
In message <20080820140702.59a7ef68 at hskinnemo-gx745.norway.atmel.com>
Haavard Skinnemoen wrote:
>
> > I've seen 2 others functions which are commom.
> >
> > Could we use the patch that reply to this message instead?
>
> The only downside that I can think of is that configuration that truly
> don't require strmhz() and don't use --gc-sections will end up slightly
> larger.
I agree with Haavard's comment - the other functions should be added
as separate source files, too.
BTW: you mentioned "two other functions", but your patch handles only
one other function - init_baudrate() ?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There is, however, a strange, musty smell in the air that reminds me
of something...hmm...yes...I've got it...there's a VMS nearby, or I'm
a Blit. - Larry Wall in Configure from the perl distribution
More information about the U-Boot
mailing list