[U-Boot] [PATCH] Add CONFIG_HDBOOTCOMMAND to the environment

Wolfgang Denk wd at denx.de
Fri Aug 22 01:35:13 CEST 2008


Dear Kumar Gala,

In message <1219350079-25416-1-git-send-email-galak at kernel.crashing.org> you wrote:
> Provide a boot command for being able to boot from a hard drive
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
>  common/env_common.c  |    3 +++
>  common/environment.c |    3 +++
>  tools/env/fw_env.c   |    3 +++
>  3 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/common/env_common.c b/common/env_common.c
> index d51c211..271e71f 100644
> --- a/common/env_common.c
> +++ b/common/env_common.c
> @@ -64,6 +64,9 @@ uchar default_environment[] = {
>  #ifdef	CONFIG_BOOTCOMMAND
>  	"bootcmd="	CONFIG_BOOTCOMMAND		"\0"
>  #endif
> +#ifdef	CONFIG_HDBOOTCOMMAND
> +	"hdboot="	CONFIG_HDBOOTCOMMAND		"\0"
> +#endif
>  #ifdef	CONFIG_RAMBOOTCOMMAND
>  	"ramboot="	CONFIG_RAMBOOTCOMMAND		"\0"
>  #endif

The percentage of boards that actually have a HDD is so small that  I
do  not  think  such  an addition to these global files is justified,
especially since it is  trivial  to  add  a  definition  of  such  an
environment variable through a CONFIG_EXTRA_ENV_SETTINGS definition.

Or is there a specific reason why CONFIG_EXTRA_ENV_SETTINGS would not
work for you?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We, the unwilling, led by the unknowing, are doing the impossible for
the ungrateful. We have done so much, for so long, with so little, we
are now qualified to do anything with nothing.


More information about the U-Boot mailing list