[U-Boot] [PATCH 0/7 v7] SMDK6400 support
Guennadi Liakhovetski
lg at denx.de
Fri Aug 22 15:00:06 CEST 2008
On Fri, 22 Aug 2008, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:41 Fri 22 Aug , Guennadi Liakhovetski wrote:
> > Hi Harald,
> >
> > On Fri, 22 Aug 2008, Harald Welte wrote:
> >
> > > On Thu, Aug 14, 2008 at 10:07:37PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > > On 17:36 Mon 11 Aug , Guennadi Liakhovetski wrote:
> > > > > Version 7: further comments addressed, style cleanup, s3c64xx NAND driver
> > > > > should now handle both chip-selects correctly. USB driver unchanged,
> > > > > serial driver got a polish in its baudrate-calculation routine - thanks to
> > > > > all participants:-)
> > > > >
> > > > > Based upon nand/testing, but I'm omitting "[PATCH 2/7] Add definition for
> > > > > the AM29LV800BB AMD NOR-flash", because it has been applied by Stefan to
> > > > > cfi-flash/next. [PATCH 1/7] is in nand/testing already too.
> > > > >
> > > > > While working on this new version I hit a compilation problem, which I
> > > > > will describe in a separate email.
> > > >
> > > > Hi Harald,
> > > >
> > > > Could you take a look on this patchset?
> > >
> > > I've reviewed it now, looks all fine to me, apart from the few comments i had
> > > on the serial driver. Though I have access to a SMDK6400 I didn't do any
> > > testing of the code due to time constraints.
> >
> > Good, thanks for the review. I would suggest, we pull v7 in, and then I
> > submit two updates: document high / low precision timer option and remove
> > hardware handshake from the serial driver, ok?
>
> I'll prefer you prefer I you can before the end of the window to do a v8.
>
> Otherwise I'll apply the v7.
Please, do this. I am away this weekend, and the beginning of the next
week will be pretty busy, so, it would be _much_ easier for me, if the
patches were already in the mainline, to then post two small incremental
patches, than to regenerate all 7 of them, which, eventually, would have
to be checked / reviewed again...
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
More information about the U-Boot
mailing list