[U-Boot] [PATCH] mtd: SPI Flash: Support the STMicro Flash

Liew Tsi Chung-R5AAHP Tsi-chung.Liew at freescale.com
Fri Aug 22 19:02:06 CEST 2008


Haavard,

>> - * Copyright 2008, Network Appliance Inc.
>> + * Network Appliance Inc.
> why do you do this?

It must be accidentally deleted which is not intended to, I will resend
it again.

Mail-archive:
> ...which means that you can make these operations cheaper by using
> shift and mask instead of divide and modulo. Though I suppose a clever
> compiler might figure that out on its own...

The u-boot optimize option is set for space (-Os) not speed (-O#n). The
OPTFLAGS= -Os in <u-boot>/config.mk. If set to -O#n, the compiler will
figure it out.

> I can't find anything in the M25P80 indicating that the page size can
> be different from 256...
I will fix it. It is always 0x100, for future proof I will keep the
l2_page_size in struct member, but rename to page_size.

> This comment is misleading. The below code only works for power-of-two
> page sizes
I think the code is based on atmel.c. 

Regards,
TsiChung



More information about the U-Boot mailing list