[U-Boot] [PATCH] ppc44x: RFC: Unification of virtex5 pp440 boards

Menon, Nishanth x0nishan at ti.com
Tue Aug 26 15:02:02 CEST 2008


Ricardo,
> -----Original Message-----
> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Ricardo Ribalda
> Delgado
> Sent: Tuesday, August 26, 2008 7:52 AM
> To: monstr at seznam.cz
> Cc: u-boot at lists.denx.de; Stefan Roese; kgm at qtec.com
> Subject: Re: [U-Boot] [PATCH] ppc44x: RFC: Unification of virtex5 pp440 boards
> 
> Hi Stefan
> 
>   First of all: Thanks for taking some time in reading the patch
> 
> 
> > I looked at your patch.
> > your xparameters contain space before tab
> 
> Sorry :), BTW: do you know how to highlight this in vim?
Here is the vimrc I use:
set ts=8
if !exists("autocommands_loaded")
  let autocommands_loaded = 1
  augroup C
      autocmd BufRead *.c set cindent
  augroup END
endif
" Kernel janitor
let c_space_errors=1
highlight WhitespaceEOL ctermbg=red guibg=red
match WhitespaceEOL /\s\+$/
highlight Over80Col ctermbg=green guibg=blue
match Over80Col /\%>81v/
set backupcopy=auto,breakhardlink

also see if you can run checkpatch.pl script from linux kernel.. it usually catches most of the formatting errors..

Regards,
Nishanth Menon


More information about the U-Boot mailing list