[U-Boot] [PATCH] ppc4xx: For the Kilauea board include the new PPC4xx SDRAM Controller DDR autocalibration routine.

[Wolfgang Denk]

Dear Adam,

in message <1219816308-9501-1-git-send-email-agraham at amcc.com> you wrote:
> From: Adam Graham <agraham at amcc.com>
> 
> Signed-off-by: Adam Graham <agraham at amcc.com>
> ---
>  cpu/ppc4xx/44x_spd_ddr2.c      |   58 ++++++++++++++++++++++++++++++---------
>  cpu/ppc4xx/Makefile            |    1 +
>  include/asm-ppc/ppc4xx-sdram.h |    2 +-
>  include/configs/kilauea.h      |   15 ++++++++++
>  4 files changed, 61 insertions(+), 15 deletions(-)

Please note that I mentiononly issues not already pointed out by
Stefan.

- Please use TABs for indentation and vertical alignment, not spaces
  (piping your code through "unexpand -a" might help, assuming you
  don't have fancy printf() format strings with multiple spaces).

- Please mind the maximum line length.

> +/* Debug messages for the DDR autocalibration */
> +#define CONFIG_AUTOCALIB		"silent\0"  /* default is non-verbose */
> +

Where is #define actually being used? It looks dangerous  to  me.  In
most  cases,  you  will  use such #defines within "#ifdef" constrcuts
without actually caring about the value; and the trailing '\0'  makes
me  especially  nervous  as  it looks as if you were intending to use
this somewhere are part of the environment  settings,  but  I  cannot
find any such code.

Something seems to be missing here?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
HANDLE WITH EXTREME CARE:  This Product Contains  Minute Electrically
Charged  Particles  Moving  at  Velocities  in Excess of Five Hundred
Million Miles Per Hour.