[U-Boot] [PATCH] S3C64XX: remove broken HWFLOW support from the serial driver

Guennadi Liakhovetski lg at denx.de
Thu Aug 28 12:03:25 CEST 2008


As noted by Harald Welte, HWFLOW support in the S3C64XX serial driver is 
broken and currently unused. Remove it.

Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
---
As well as the previous patch, please, apply after the s3c64xx / smdk6400 
support is merged in.

diff --git a/drivers/serial/s3c64xx.c b/drivers/serial/s3c64xx.c
index ea6eb4b..9d8fcb9 100644
--- a/drivers/serial/s3c64xx.c
+++ b/drivers/serial/s3c64xx.c
@@ -119,22 +119,6 @@ int serial_getc(void)
 	return uart->URXH & 0xff;
 }
 
-#ifdef CONFIG_HWFLOW
-static int hwflow;		/* turned off by default */
-int hwflow_onoff(int on)
-{
-	switch (on) {
-	case 1:
-		hwflow = 1;	/* turn on */
-		break;
-	case -1:
-		hwflow = 0;	/* turn off */
-		break;
-	}
-	return hwflow;
-}
-#endif
-
 #ifdef CONFIG_MODEM_SUPPORT
 static int be_quiet;
 void disable_putc(void)
@@ -164,11 +148,6 @@ void serial_putc(const char c)
 	/* wait for room in the tx FIFO */
 	while (!(uart->UTRSTAT & 0x2));
 
-#ifdef CONFIG_HWFLOW
-	/* Wait for CTS up */
-	while (hwflow && !(uart->UMSTAT & 0x1));
-#endif
-
 	uart->UTXH = c;
 
 	/* If \n, also do \r */


More information about the U-Boot mailing list