[U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

Wolfgang Denk wd at denx.de
Thu Aug 28 23:33:35 CEST 2008


Dear vgallardo at amcc.com,

Can you please provide a real name with your mail address when
submitting patches?


In message <1219956791-5783-1-git-send-email-vgallardo at amcc.com> you wrote:

> Subject: [U-Boot] [PATCH 1/1] ppc4xx: fix UIC hang if critical or non-critical interrupt is set at the same time as a normal interrupt is set on UIC0

This is an awfully long subject line.

As you are probably aware, the Subject line will be used as  part  of
the git commit message, and it will be shown as "title" of your patch
by tools like "git log" or "gitk" etc.

However, these tools will truncate the line after 70 characters. That
means, your commit message will read:

commit ...
Author: <vgallardo at amcc.com>
Date:   ...

    ppc4xx: fix UIC hang if critical or non-critical interrupt is set at


This is not exactly useful, is it?


So please use SHORT subject lines and provide the explanation in the
message body.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man muß nur versuchen,
es noch einmal zu denken.          -- Goethe, Maximen und Reflexionen


More information about the U-Boot mailing list