[U-Boot] [PATCH 06/12 V2] autoscript: Move conditional compilation to Makefile

Wolfgang Denk wd at denx.de
Fri Aug 29 15:10:49 CEST 2008


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1220005348-19536-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  common/Makefile                           |    4 +-
>  common/{cmd_autoscript.c => autoscript.c} |   44 --------
>  common/cmd_autoscript.c                   |  158 -----------------------------
>  3 files changed, 3 insertions(+), 203 deletions(-)

Patch description (Mode conditional compilation to Makefile) and patch
content (major code reorganisation) don't match.


What is th eintention of splitting up cmd_autoscript.c into two files?
This makes no sense to me.

Also, when we reorganize this, than including the preparations to
rename the command as planned.


I suggest we just do that the SUbject says, i. e. deal with the
Makefile changes, and leave the rest for now.


Please clean up and resubmit.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
      Bugs are by far the largest and  most successful class of
      entity, with nearly a million known species. In this res-
      pect they outnumber all the other  known  creatures about
      four to one.  -- Professor Snope's Encyclopedia of Animal


More information about the U-Boot mailing list