[U-Boot] [PATCH 3/6] "return" is not a function

Guennadi Liakhovetski lg at denx.de
Sun Aug 31 18:10:04 CEST 2008


On Sun, 31 Aug 2008, Wolfgang Denk wrote:

> Dear Guennadi Liakhovetski,
> 
> In message <Pine.LNX.4.64.0808271746380.6718 at axis700.grange> you wrote:
> > Signed-off-by: Guennadi Liakhovetski <lg at denx.de>
> 
> I don't see any need to change this code. Patch rejected.

return (0) and similar produce warnings from checkpatch.pl. If I followed 
this local style and used parenthesis in all returns I added, all of them 
would cause checkpatch warnings. If I only added returns without 
parenthesis the mixed style would look terrible. So, I consider this a 
coding style clean up, just as well as any space vs. tab, or brace on the 
same line as if or for or...

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de


More information about the U-Boot mailing list