[U-Boot] [PATCH 0/6] Support NAND in fw_printenv/fw_setenv

[Guennadi Liakhovetski]

On Sun, 31 Aug 2008, Wolfgang Denk wrote:

> Dear Guennadi Liakhovetski,
> 
> In message <Pine.LNX.4.64.0808271741250.6718 at axis700.grange> you wrote:
> > What follows is a patch series to support NAND environment under Linux, 
> > including bad blocks. In principle, this is just one logical change, but 
> > it is a big one... So I split it into 6 smaller patches, which should be 
> > easier to review. Tested with and without redundant environment, with an 
> > injected bad block, crossing block border, read and write.
> 
> I just tried building for older kernels - it doesn't work:
> 
> -> make env MTD_VERSION=old
> make -C tools/env all MTD_VERSION=old || exit 1
> make[1]: Entering directory `/home/wd/git/u-boot/tmp/tools/env'
> ppc_8xx-gcc -Wall -DUSE_HOSTCC -I/home/wd/git/u-boot/tmp/include -DMTD_OLD crc32.c  fw_env.c  fw_env_main.c -o fw_printenv
> In file included from /home/wd/git/u-boot/tmp/include/linux/mtd/mtd.h:13,
>                  from fw_env.c:36:
> /home/wd/git/u-boot/tmp/include/linux/mtd/mtd-abi.h:15: error: parse error before "uint32_t"
> /home/wd/git/u-boot/tmp/include/linux/mtd/mtd-abi.h:15: warning: no semicolon at end of struct or union
> /home/wd/git/u-boot/tmp/include/linux/mtd/mtd-abi.h:16: warning: type defaults to `int' in declaration of `length'
> /home/wd/git/u-boot/tmp/include/linux/mtd/mtd-abi.h:16: warning: data definition has no type or storage class
...

Ok, how about this: we leave the current fw_env.c as it is, I submit 
_exactly_ the state after applying my 6 patches as a new file, with 
suitable changes to the Makefile, fix building with MTD_VERSION=old, and 
try to improve comments in the code. Would this be accepted?

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de