[U-Boot-Users] [PATCH] add support for Toradex Colibri module

[Wolfgang Denk]

Dear Daniel,

in message <20071130231335.GA10869 at buzzloop.caiaq.de> you wrote:
> 
> Patch against 1.3.0 is attached.
> 
> Best regards,
> Daniel
> 
> 
>  MAKEALL                       |    1 
>  Makefile                      |    3 
>  board/colibri/Makefile        |   51 ++++
>  board/colibri/colibri.c       |   61 +++++
>  board/colibri/config.mk       |    1 
>  board/colibri/lowlevel_init.S |  465 ++++++++++++++++++++++++++++++++++++++++++
>  board/colibri/pxavoltage.S    |  178 ++++++++++++++++
>  board/colibri/u-boot.lds      |   56 +++++
>  include/asm-arm/mach-types.h  |   13 +
>  include/configs/colibri.h     |  261 +++++++++++++++++++++++
>  10 files changed, 1090 insertions(+)

There are coding style issues with your patch: trailing white space,
C++ comments, indentation not by multiples of 8 characters.

Please clean up and resubmit.

And while you are at it - please keep lists sorted (MAKEALL,
Makefile).



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He had been eight years upon a project for extracting sunbeams out of
cucumbers, which were to be put in vials hermetically sealed, and let
out to warm the air in raw inclement summers.        - Jonathan Swift
              _Gulliver's Travels_ ``A Voyage to Laputa, etc.'' ch. 5