[U-Boot-Users] [PATCH] ARM: S3C24x0 SoC NAND controller support

Wolfgang Denk wd at denx.de
Mon Feb 4 23:55:47 CET 2008


In message <20071219141052.GC29882 at prithivi.gnumonks.org> you wrote:
> This patch adds NAND support to the S3C24x0 SoC code in u-boot
> 
> Signed-off-by: Harald Welte <laforge at openmoko.org>

Applied, thanks - but ...

> Index: u-boot/cpu/arm920t/s3c24x0/Makefile
> ===================================================================
> --- u-boot.orig/cpu/arm920t/s3c24x0/Makefile
> +++ u-boot/cpu/arm920t/s3c24x0/Makefile
> @@ -26,7 +26,7 @@
>  LIB	= $(obj)lib$(SOC).a
>  
>  COBJS	= i2c.o interrupts.o serial.o speed.o \
> -	  usb.o usb_ohci.o
> +	  usb.o usb_ohci.o nand.o

Please keep lists of names sorted, and mind the coding style:

...
warning: 1 line applied after fixing whitespace errors.
...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real computer scientists don't comment their  code.  The  identifiers
are so long they can't afford the disk space.




More information about the U-Boot mailing list