[U-Boot-Users] [PATCH] ARM926: compile cpu_init_crit function only if CONFIG_SKIP_LOWLEVEL_INIT is not defined

[Hebbar]

Hi Wolfgang ,

At Present the call to "cpu_init_crit" in uboot/cpu/arm926ejs/start.S (142)
is under ifndef

#ifndef CONFIG_SKIP_LOWLEVEL_INIT
	bl	cpu_init_crit
#endif

  But the function definition (203) isn't under this ifndef. So irrespective
of CONFIG_SKIP_LOWLEVEL_INIT, this function is compiled. Hence i have
applied the ifndef to function definition which places the entire
cpu_init_crit inside the ifndef.

Regards
Gururaja


In message <14408491.post at talk.nabble.com> you wrote:
> 
> This patches allows cpu_init_crit function to be compilled only if
> CONFIG_SKIP_LOWLEVEL_INIT is not defined. At present irrespective of
> CONFIG_SKIP_LOWLEVEL_INIT, cpu_init_crit is always compilled. This is for
> arm926ejs module. 

I'm not sure about this one. Probably the whole  cpu_init_crit:  part
should be placed inside the "#ifndef CONFIG_SKIP_LOWLEVEL_INIT" part,
as it is done for example in "cpu/arm920t/start.S" ?

Not applied.


Best regards,

Wolfgang Denk
-- 
View this message in context: http://www.nabble.com/-PATCH--ARM926%3A-compile-cpu_init_crit-function-only-if-CONFIG_SKIP_LOWLEVEL_INIT-is-not-defined-tp14408413p15281823.html
Sent from the Uboot - Users mailing list archive at Nabble.com.