[U-Boot-Users] [PATCH v4] QE IO: Add initial data to pin configuration + read/write functions

[Timur Tabi]

David Saada wrote:

>> Don't use volatile.  Use the accessor functions: in_be32 and out_be32.
> This was copied from the qe_config_iopin function, which still used the
> volatile directive. I can fix it there as well, but I see that it's used
> everywhere. 

Yeah, and it's wrong everywhere, too.

> Maybe this needs a thorough change, but I'm not sure it
> should be in my humble patch.

Well, we may not have the time to fix all the wrong usages, but we shouldn't 
make it worse.  All new code should use the accessors.

>> Put these in a header file.
> Will change as well. I think ioports.h is good enough for this purpose.
> So far, qe_config_iopin wasn't there as well, so it will also be moved
> there.

I'm okay with that.

-- 
Timur Tabi
Linux kernel developer at Freescale