[U-Boot-Users] [PATCH] 83xx: Add Vitesse VSC7385 firmware uploading

Timur Tabi timur at freescale.com
Thu Feb 7 23:35:39 CET 2008


Kim Phillips wrote:

> I'd prefer firmware uploading bits remain apps (perhaps in examples/?)
> but I don't know the "U-Boot Philosophy" for this area..

The whole point behind this patch is to get rid of the currently application and 
make this a native feature of U-Boot.

In this regard, it is no different than my QE firmware patch.

> drivers/net bits go through net maintainer, Ben Warren (separate patch).

I can break it into two patches.

>> +#include <config.h>
>> +#include <common.h>
>> +#include <asm/io.h>
>> +#include <asm/errno.h>
> 
> This breaks some archs.

Which ones?  How?  These header files look pretty harmless to me.  What if I did 
this:

#include <config.h>

#ifdef CONFIG_VSC7385_ENET

#include <common.h>
#include <asm/io.h>
#include <asm/errno.h>

> who is the original author of this code?

One of our BSP developers.  I took the code from his application and cleaned it up.

-- 
Timur Tabi
Linux kernel developer at Freescale




More information about the U-Boot mailing list