[U-Boot-Users] [PATCH 0/3] PPC: Barco SMD 8245/8347E boards

[Wolfgang Denk]

In message <20080208160235.GI4149 at chiana.homelinux.org> you wrote:
> 
> In the following mails, we'll be submitting a number of patches to
> include support of 8 new Barco Boards:
> 
> Barco SVC2
> Barco NGS101
> Barco H-DGUC
> Barco NGP101
> Barco NGS103
> Barco NGS104
> Barco NGS105
> Barco NGS107
> 
> 1. remove-barco-uboot.diff
> Since my first submission to the mailing list was rather naive (the board
> name was the company name), the first patch will remove the existing
> barco platform from the source tree (to include it again afterwards).
> 
> 2. barco_smd_barco8245g1.diff
> The second patch provides an updated version of what was removed in
> remove-barco-uboot.diff and adds two extra boards: NGS101 and H-DGUC.

Please don't.

Don't remove + re-add, as this breaks history. Use rename, and use git
to create a patch that shows the rename instead of remove/add.

Second, please do only one thing per patch. If you want to add two
boards, then submit two separate patches.

This will also help to keep your patches in an acceptable size.


> 3. barco_smd_barco8347g1.diff
> The third patch adds support for 6 new boards (SVC2, NGS103, NGS104, NGS105
> and NGS107 and NGP101). This board port is a branch off Denx' MPC8349EMDS
> port, but since a lot of specific stuff got included, we branced it to
> a seperate platform in order to avoid 'polluting' mpc8349emds.c.

Please separate patches, one per board.

> This board re-used/re-creates the board/barco/ dir in which the several
> board families will be placed (from other divisions/branches).
> board/<vendor>/<boardport>/

board/barco/ should have been used in the first patch above already.

Also, there are cosing style violations with youyr patches: C++
comments, indentation not by TAB, incorrect comment style, too long
lines, code in "#if 0" blocks, etc.

It seems you are using custom flah code even though you have CFI
conformant flashes. Please don't - use the CFI driver instead.

Also, I didn't see signed-off-by lines.

Please cleanup and resubmit. [I will reject  the  submitted  patches,
because of their size and because of the problems mentioned above.]

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It's a small world, but I wouldn't want to paint it.