[U-Boot-Users] [PATCH] ide arm support

[michael]

Hi
> On Mon, Feb 11, 2008 at 10:30:08PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
>   
>> On 21:40 Mon 11 Feb     , michael wrote:
>>     
>>> --- a/common/cmd_ide.c
>>> +++ b/common/cmd_ide.c
>>> @@ -934,7 +934,14 @@ output_data(int dev, ulong *sect_buf, int words)
>>>  static void
>>>  output_data(int dev, ulong *sect_buf, int words)
>>>  {
>>> +#ifndef __ARM__
>>>  	outsw(ATA_CURR_BASE(dev)+ATA_DATA_REG, sect_buf, words<<1);
>>> +#else
>>> +	int i = words;
>>>       
>> Why do you initialise "i" with words and re-initialize it at 0 in for?
>>     
> And why do you need this ungly #ifdef at all?
>
> 	ladis
>
>   
The code is fill with ugly ifdef. Can you suggest me something better?

Michael