[U-Boot-Users] [PATCH v2] MPC85xx, MPC83xx: Add/Fix UPM configuration support

David Saada David.Saada at ecitele.com
Tue Feb 12 10:46:18 CET 2008


> > Definitely true, but that's a delicate change. For instance, this
UPM
> > patch has the same logics for the 83xx & 85xx platforms, but the
> > registers are different. Unifying this code should result in lots of
> > ugly ifdefs.
> 
> which registers are different?

Well, not quite the register structures, but more the way they are
accessed. For instance, the BRx registers are accessed differently in
the 83xx (via the lbus array) comparing to the 85xx (via lbc). In the
ioports code, for instance, the code has the same logics for both
platforms, but the registers are accessed via different structures, and
even have different names (dir1 vs. cpdir1 for instance). I think this
kind of change would also require changes in the register definition
files, if we want the unified code to be clear.

David.




More information about the U-Boot mailing list