[U-Boot-Users] [PATCH] Add 'imload' command

[Kumar Gala]

On Feb 13, 2008, at 2:22 PM, Bartlomiej Sieka wrote:

> Kumar Gala wrote:
> [...]
>>>>> - The load_image routine (and consequently imload commad) will  
>>>>> not work when the image is stored in Data Flash.
>>>> what's the issue here?
>>>
>>> Please have a look at code under CONFIG_HAS_DATAFLASH in  
>>> get_kernel()
>>> (formerly in do_bootm()), especially the read_dataflash()  
>>> function. The
>>> issue is that you have to copy data from Data Flash in a specific  
>>> way in
>>> order to have random access to it. So for example this line in  
>>> your code:
>>> type_name = image_get_type_name (image_get_type (hdr));
>>> will effectively try to access hdr->ih_type, which will not work  
>>> when
>>> hdr is an address in Data Flash.
>> Just to be clear, at a quick glance, I assume load_image will work  
>> ok from do_bootm() but not from do_imload().  (since do_bootm is  
>> calling get_kernel).
>
> Correct.

Ok, I don't know much about the DATAFLASH device, but is it any  
different than reading from something like NAND or a HD?  It seems  
like we shouldn't burden the code w/providing special handling for  
accessing it if its not directly memory accessible like NOR flash is.

- k