[U-Boot-Users] [PATCH] Add 'imload' command

[Kumar Gala]

On Feb 13, 2008, at 4:31 PM, Wolfgang Denk wrote:

> In message <Pine.LNX. 
> 4.64.0802122307330.22593 at blarg.am.freescale.net> you wrote:
>> 'imload' provides a more direct means to load from an image file.
>
> What exactly is an "image file" here (which sorts of images are
> allowed?) and what does "load" mean (which actions are performed on
> the file)?

its suppose to be a 'uImage' not sure what the base way to refer to  
that is.

>> Also created a load_image routine out of the code in do_bootm() that
>> is shared between do_bootm() and do_imload().
>
> Hm... bootm is restrictred to a certain sub-set of image types. imload
> on the other hand sounds pretty generic to me and should not have such
> restrictions.

what other image formats should we be supporting?

>> +	switch (image_get_comp (hdr)) {
>> +	case IH_COMP_NONE:
>> +		if (dst == (ulong)hdr) {
>> +			printf ("   XIP %s ... ", type_name);
>
> This is an ugly hack in the old code that should be removed by the new
> implementation.
>
>> +	"imload  - load image from application image\n",
>> +	"[addr] [load addr]\n"
>
> What exactly is an "application image" ?

I stole this from iminfo help.

>> +	"    - load image from application image located at address  
>> 'addr'\n"
>> +	"      or $loadaddr if 'addr' is not provided to either the load\n"
>> +	"      address specified in the application image header or the\n"
>> +	"      'load addr' argument; this includes verification of the\n"
>> +	"      image contents (magic number, header and payload checksums) 
>> \n"
>
> Please be terse. We don't want to spend the memory footprint on prosa.

no problem :)

- k