[U-Boot-Users] [PATCH] Do not specify a CROSS_COMPILE default when executing size

[Mike Frysinger]

On Wednesday 13 February 2008, Wolfgang Denk wrote:
> In message <1201517779-23878-1-git-send-email-vapier at gentoo.org> you wrote:
> > Signed-off-by: Mike Frysinger <vapier at gentoo.org>
> > ---
> >  MAKEALL |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/MAKEALL b/MAKEALL
> > index d66a5fa..2aff4da 100755
> > --- a/MAKEALL
> > +++ b/MAKEALL
> > @@ -721,7 +721,7 @@ build_target() {
> >  	${MAKE} ${JOBS} all 2>&1 >${LOG_DIR}/$target.MAKELOG \
> >
> >  				| tee ${LOG_DIR}/$target.ERR
> >
> > -	${CROSS_COMPILE:-ppc_8xx-}size ${BUILD_DIR}/u-boot \
> > +	${CROSS_COMPILE}size ${BUILD_DIR}/u-boot \
>
> What exactly is bad about using this default?

the default is useless for non-ppc systems ?  try and run the MAKEALL script 
on a system that lacks ppc_8xx- and CROSS_COMPILE is not set and you get an 
error about ppc_8xx-size not existing and no useful output at all.  imagine 
that.

here's a better question: why is ppc_8xx- a better default than `size` ?  you 
cant build u-boot on a system that lacks a host compiler and it is 
unrealistic to cover the case where the host `size` does not exist.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20080213/c999d065/attachment.pgp