[U-Boot-Users] [PATCH] Add call command on PPC

Wolfgang Denk wd at denx.de
Fri Feb 15 09:30:57 CET 2008


In message <ECB2C6CF-0AB8-44AE-AD35-769B741B0528 at kernel.crashing.org> you wrote:
> 
> The main reason for me doing this was to provide a "generic" mechanism  
> that mimic how we boot kernels on PPC.

May I ask why exactly this is needed at all? Kernels should be booted
using the bootm command - if somethingis missing there, it should  be
added  /  fixed  in  this  contexzt  instead of adding another highly
specialized command.

And *if* we add this, then please let's make it general enough so  we
can use it on all architectures without adding a lot of #ifdef mess.

> The other issue w/providing this on all arch's is that the number of  
> params passed via regs may vary and I don't know what is for arm,  
> avr32, blackfin, i386, m68k, microblaze, mips, nios, nios2, and sh.
> and each variation will require a different prototype.

No, just change the design, then. Make it a varargs function and pass
the number of registers as one argument.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Death. Destruction. Disease. Horror. That's what war  is  all  about.
That's what makes it a thing to be avoided.
	-- Kirk, "A Taste of Armageddon", stardate 3193.0




More information about the U-Boot mailing list