[U-Boot-Users] [patch] do not use cmd_reset uninitialized in cfi_flash.c

[Stefan Roese]

On Monday 18 February 2008, Michael Schwingen wrote:
> > Right. But it will be an improvement to the current implementation, where
> > a random command is written as RESET command. And also an improvement to
> > the fixed AMD/Intel RESET command. So I vote for trying this solution.
> > I'll test on a few of mine platforms too.
> >
> > Michael, could please you provide a patch?
>
> Okay - sorry, I did not have time for as much testing as I planned.

This sounds familiar. :)

> From a short test, it looks like AMD-style flash roms treat *any* unknown
> command write as a reset, at least when in CFI Query mode, so issuing the
> Intel reset command to AMD-style flashs seems safe (from the small sample I
> have), plus the 3-cycle magic sequence should kick the state machine into
> the right state even without a reset command. Since the AMD-style flashs
> require the unlock sequence for real operation, I chose to try the AMD
> reset command first, so that Intel flashs do no see an invalid command
> prior to the CFI query.
>
> I have tested the patch on AM29LV320-style flashs from Fujitsu and
> Macronix, plus Intel StrataFlash.

I'll test it on some platforms here too (Intel & Spansion) and if nobody 
objects I'll commit your patch and ask Wolfgang to pull into the 1.3.2 
release, since it's a bug fix.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================