[U-Boot-Users] [PATCH 4/8] [Makefile] Sort COBJS in lib_<arch> Makefiles

Marian Balakowicz m8 at semihalf.com
Wed Feb 27 12:24:01 CET 2008


Jon Loeliger wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> 
>> It will be nice if you could split it in 1 line for 1 file as it
>>
>>  -SOBJS    = memcpy.o memcmp.o memset.o memmove.o
>>  +SOBJS    += memcmp.o
>>  +SOBJS    += mmemcpy.o
>>  +SOBJS    += memmove.o
>>  +SOBJS    += memset.o
>> .....
>>>  SRCS     := $(SOBJS:.o=.S) $(COBJS:.o=.c)
>>>  OBJS    := $(addprefix $(obj),$(SOBJS) $(COBJS))
>>> diff --git a/lib_i386/Makefile b/lib_i386/Makefile
>>
>> Best regards,
>> J.
>>
> 
> Yes, please.  But also, while you are there, we need to
> go one step further and convert to SOBJS-y and COBJS-y
> as well.
> 
> If you don't do it, I will eventually be converting them all to look
> like this:
> 
>    COBJS-y    += file.o
>    COBJS-y    += other.o
> 
>    OBJS    := $(addprefix $(obj),$(SOBJS-y) $(COBJS-y))
> 
> Might as well head in that direction as we go along...

Done, updated version of the commit will cover this.

Cheers,
m.




More information about the U-Boot mailing list